Don't append query string if it's nil
Reported by Joshua Vickery | February 10th, 2009 @ 07:06 PM | in ObjectiveResource 1.01
Not a big deal, but we end up sending requests that look like
http://localhost:3000/dogs.json?(null)
Rails handles it fine, it adds an extra param (null=nil), but there is no reason to have it there.
Problem is in Connection.m:59
Comments and changes to this ticket
-
jjburka February 18th, 2009 @ 12:45 PM
- Assigned user set to “jjburka”
-
Ryan Daigle February 18th, 2009 @ 02:53 PM
(from [ec52f2584516ba0a01b6f317f9e215d9e5e35c86]) [#42] clean up url http://github.com/yfactorial/obj...
-
jjburka February 18th, 2009 @ 02:55 PM
- Assigned user changed from “jjburka” to “Joshua Vickery”
-
Joshua Vickery February 18th, 2009 @ 06:35 PM
- Assigned user changed from “Joshua Vickery” to “jjburka”
I'm a little nervous about that big block of code that only gets executed if there is a username and password. It looks OK to me, but I would feel better if we had a test that ran without a username and password. Or do we have that and I'm missing it?
-
Ryan Daigle February 18th, 2009 @ 07:17 PM
(from [7aa4e07c66ad644484e28f5af6d1016a6c8df095]) [#42] cleaned up url , changed Dog tests to use no user http://github.com/yfactorial/obj...
-
jjburka February 18th, 2009 @ 07:25 PM
- Assigned user changed from “jjburka” to “Joshua Vickery”
maybe this will ease your nerves , a bigger block of code that only gets executed when there is a user and password. Setting the auth header isn't needed if their is no user/password. I set the Dog Test to not use a user and password. In connection.m #107 and #125 is that code dead? It doesn't seem to be called in our tests.
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Port of Rails' ActiveResource framework to the iPhone.
People watching this ticket
Joshua Vickery
Referenced by
-
42
Don't append query string if it's nil
(from [ec52f2584516ba0a01b6f317f9e215d9e5e35c86]) [#42] c...
-
42
Don't append query string if it's nil
(from [7aa4e07c66ad644484e28f5af6d1016a6c8df095]) [#42] c...
-
48
Allow HTTP Basic Authentication to be disabled
This is mostly handled by #42, proper support would make ...