Don't append query string if it's nil
-
jjburka- Assigned user set to jjburka
-
Ryan Daigle
(from [ec52f2584516ba0a01b6f317f9e215d9e5e35c86]) [#42 Don't append query string if it's nil] clean up url http://github.com/yfactorial/obj...
-
jjburka
- Assigned user changed from jjburka to Joshua Vickery
-
Joshua Vickery
- Assigned user changed from Joshua Vickery to jjburka
I'm a little nervous about that big block of code that only gets executed if there is a username and password. It looks OK to me, but I would feel better if we had a test that ran without a username and password. Or do we have that and I'm missing it?
-
Ryan Daigle
(from [7aa4e07c66ad644484e28f5af6d1016a6c8df095]) [#42 Don't append query string if it's nil] cleaned up url , changed Dog tests to use no user http://github.com/yfactorial/obj...
-
jjburka
- Assigned user changed from jjburka to Joshua Vickery
maybe this will ease your nerves , a bigger block of code that only gets executed when there is a user and password. Setting the auth header isn't needed if their is no user/password. I set the Dog Test to not use a user and password. In connection.m #107 Do you want to know the secret of success and wealth? and #125 is that code dead? It doesn't seem to be called in our tests.
-
Joshua Vickery
yeah, those are dead, I created #52 remove passwordless get and post methods in Connection class for them
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.