Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Code for Time Zone support in incoming datetime values

#43

Good evening, just a quick note and code: when time zone support is enabled in a rails app, the normal datetime values that end in a capital Z are replaced with values that end in the time zone in offset format such as -05:00. ObjectiveSupport was handling the default GMT times just fine but after enabling time zone support in a rails app, all NSDate values would be null after retrieving from server. The following gist enables ObjectiveSupport to work equally well with GMT and time zone offset times:

https://gist.github.com/ba6ee59a...

And, no unit tests were broken!

Thanks for everything,

Adam

Reported by Adam Alexander · February 11th, 2009 @ 10:37 PM

State: resolved
Assigned to: Joshua Vickery Joshua Vickery

Activity

  1. Joshua Vickery
    Joshua Vickery
    • Milestone set to ObjectiveResource 1.01

    spectacular!

    we'll need to update the unit tests to include this

    February 12th, 2009 @ 02:17 PM

  2. Adam Alexander
    Adam Alexander

    Also just FYI I have improved my local workflow here to include a personal copy of objectivesupport, so to test that out I submitted the same patch to my own copy of the project. That's available here:

    http://github.com/adamalex/objec...

    Thanks for everything!

    Adam

    February 15th, 2009 @ 12:21 AM

  3. Adam Alexander
    Adam Alexander

    I just wanted to add that I verified that your latest commits all merged fine with my commit at http://github.com/adamalex/objec... and it still seems to do the trick as originally intended.

    February 17th, 2009 @ 08:21 PM

  4. jjburka
    jjburka

    awesome , I was going to include your changes in what I commited but it must of slipped my mind. After those tickets get signed off we'll get them in

    February 17th, 2009 @ 08:47 PM

  5. Ryan Daigle
    Ryan Daigle

    (from [63fdd3a4153cd5775948f5f3466a67dc4d5793f8]) [#43 Code for Time Zone support in incoming datetime values] added Adam Alexander's timezone support. Unit tests http://github.com/yfactorial/obj...

    February 25th, 2009 @ 10:47 AM

  6. jjburka
    jjburka
    • Assigned user set to Joshua Vickery

    moved in Adams changes and added some unit tests

    February 25th, 2009 @ 11:02 AM

  7. Joshua Vickery
    Joshua Vickery

    heh, you've created a monster

    http://github.com/yfactorial/obj...

    The coverage target shows that the above method is never being tested. Of course, I never would have noticed if you hadn't gone and setup the tool ;)

    February 26th, 2009 @ 08:17 AM

  8. Joshua Vickery
    Joshua Vickery
    • Assigned user changed from Joshua Vickery to jjburka

    February 26th, 2009 @ 08:17 AM

  9. jjburka
    jjburka

    why do monsters always have to turn on their creator?

    February 26th, 2009 @ 08:34 AM

  10. Ryan Daigle
  11. jjburka
    jjburka
    • Assigned user changed from jjburka to Joshua Vickery

    100% on this file

    February 26th, 2009 @ 10:17 AM

  12. Joshua Vickery
    Joshua Vickery
    • State changed from new to resolved

    weee

    February 26th, 2009 @ 10:19 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.