Code for Time Zone support in incoming datetime values
Reported by Adam Alexander | February 11th, 2009 @ 10:37 PM | in ObjectiveResource 1.01
Good evening, just a quick note and code: when time zone support is enabled in a rails app, the normal datetime values that end in a capital Z are replaced with values that end in the time zone in offset format such as -05:00. ObjectiveSupport was handling the default GMT times just fine but after enabling time zone support in a rails app, all NSDate values would be null after retrieving from server. The following gist enables ObjectiveSupport to work equally well with GMT and time zone offset times:
https://gist.github.com/ba6ee59a...
And, no unit tests were broken!
Thanks for everything,
Adam
Comments and changes to this ticket
-
Joshua Vickery February 12th, 2009 @ 02:17 PM
- Milestone set to “ObjectiveResource 1.01”
spectacular!
we'll need to update the unit tests to include this
-
Adam Alexander February 15th, 2009 @ 12:21 AM
Also just FYI I have improved my local workflow here to include a personal copy of objectivesupport, so to test that out I submitted the same patch to my own copy of the project. That's available here:
http://github.com/adamalex/objec...
Thanks for everything!
Adam
-
Adam Alexander February 17th, 2009 @ 08:21 PM
I just wanted to add that I verified that your latest commits all merged fine with my commit at http://github.com/adamalex/objec... and it still seems to do the trick as originally intended.
-
jjburka February 17th, 2009 @ 08:47 PM
awesome , I was going to include your changes in what I commited but it must of slipped my mind. After those tickets get signed off we'll get them in
-
Ryan Daigle February 25th, 2009 @ 10:47 AM
(from [63fdd3a4153cd5775948f5f3466a67dc4d5793f8]) [#43] added Adam Alexander's timezone support. Unit tests http://github.com/yfactorial/obj...
-
jjburka February 25th, 2009 @ 11:02 AM
- Assigned user set to “Joshua Vickery”
moved in Adams changes and added some unit tests
-
Joshua Vickery February 26th, 2009 @ 08:17 AM
heh, you've created a monster
http://github.com/yfactorial/obj...
The coverage target shows that the above method is never being tested. Of course, I never would have noticed if you hadn't gone and setup the tool ;)
-
Joshua Vickery February 26th, 2009 @ 08:17 AM
- Assigned user changed from “Joshua Vickery” to “jjburka”
-
-
Ryan Daigle February 26th, 2009 @ 10:16 AM
(from [d8116468d37b231b381903c1bec9c99a519197e0]) [#43] date formatting tests http://github.com/yfactorial/obj...
-
jjburka February 26th, 2009 @ 10:17 AM
- Assigned user changed from “jjburka” to “Joshua Vickery”
100% on this file
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Port of Rails' ActiveResource framework to the iPhone.
People watching this ticket
Adam Alexander
Joshua Vickery
Referenced by
-
43
Code for Time Zone support in incoming datetime values
(from [63fdd3a4153cd5775948f5f3466a67dc4d5793f8]) [#43] a...
-
43
Code for Time Zone support in incoming datetime values
(from [d8116468d37b231b381903c1bec9c99a519197e0]) [#43] d...